Integrated: 8286943: G1: With virtualized remembered sets, maximum number of cards configured is wrong
Thomas Schatzl
tschatzl at openjdk.java.net
Fri May 20 07:43:45 UTC 2022
On Wed, 18 May 2022 15:22:03 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> can I get reviews for this change that fixes passing a wrong parameter value to card set configuration that
>
> * prevents upgrading a Howl container to Full with virtualized remembered sets (Heap regions >= 64M) as the (default) threshold for coarsening from Howl to Full is max_cards_in_cardset * 0.9, which is always higher than the value tested against (65k, max card set container element number).
> * and also unnecessarily increases the bits used for inline ptrs
>
> I added some basic parameter verification to the main constructor which would have caught this issue.
>
> Testing: gha, tier1-3
>
> Thanks,
> Thomas
This pull request has now been integrated.
Changeset: 6569666b
Author: Thomas Schatzl <tschatzl at openjdk.org>
URL: https://git.openjdk.java.net/jdk/commit/6569666b050e8b6f3a0aae7d14d96007a1e429b3
Stats: 35 lines in 4 files changed: 28 ins; 0 del; 7 mod
8286943: G1: With virtualized remembered sets, maximum number of cards configured is wrong
Reviewed-by: ayang, iwalulya
-------------
PR: https://git.openjdk.java.net/jdk/pull/8773
More information about the hotspot-gc-dev
mailing list