RFR: 8286943: G1: With virtualized remembered sets, maximum number of cards configured is wrong

Thomas Schatzl tschatzl at openjdk.java.net
Fri May 20 07:43:44 UTC 2022


On Thu, 19 May 2022 17:52:04 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I get reviews for this change that fixes passing a wrong parameter value to card set configuration that
>> 
>> * prevents upgrading a Howl container to Full with virtualized remembered sets (Heap regions >= 64M) as the (default) threshold for coarsening from Howl to Full is max_cards_in_cardset * 0.9, which is always higher than the value tested against (65k, max card set container element number).
>> * and also unnecessarily increases the bits used for inline ptrs
>> 
>> I added some basic parameter verification to the main constructor which would have caught this issue.
>> 
>> Testing: gha, tier1-3
>> 
>> Thanks,
>>   Thomas
>
> Marked as reviewed by iwalulya (Reviewer).

Thanks @walulyai @albertnetymk for your reviews

-------------

PR: https://git.openjdk.java.net/jdk/pull/8773



More information about the hotspot-gc-dev mailing list