RFR: 8314157: G1: "yielded" is not initialized on some paths after JDK-8140326 [v3]

[Ivan Walulya]

On Mon, 21 Aug 2023 15:16:49 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   can I have reviews for this change that fixes a bug with with some variable not being initialized, leading to (minor) unnecessary work.
>> 
>> The use of the `yielded` variable is an optimization to not re-check TARSes again if there has been no yielding (safepoint) while processing. Maybe it is useful to remove it because the re-echeck for TARS isn't that expensive anyway.
>> 
>> Testing: tier1-3
>> 
>> Thanks,
>>   Thomas
>> 
>> Note: this has been edited to only cover the uninitialized variables after after @albertnetymk pointed out that the original error analysis has been wrong. There is some more information in the CR about the original analysis.
>
> Thomas Schatzl has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Remove yielded flag
>  - Statistics for old regions in the collection set will be/are cleared unconditionally in G1ClearBitmapClosure already, so no issue here.

Marked as reviewed by iwalulya (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/15359#pullrequestreview-1590761039