Integrated: 8314157: G1: "yielded" is not initialized on some paths after JDK-8140326
Thomas Schatzl
tschatzl at openjdk.org
Wed Aug 23 09:47:45 UTC 2023
On Mon, 21 Aug 2023 08:53:34 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> can I have reviews for this change that fixes a bug with with some variable not being initialized, leading to (minor) unnecessary work.
>
> The use of the `yielded` variable is an optimization to not re-check TARSes again if there has been no yielding (safepoint) while processing. Maybe it is useful to remove it because the re-echeck for TARS isn't that expensive anyway.
>
> Testing: tier1-3
>
> Thanks,
> Thomas
>
> Note: this has been edited to only cover the uninitialized variables after after @albertnetymk pointed out that the original error analysis has been wrong. There is some more information in the CR about the original analysis.
This pull request has now been integrated.
Changeset: 742e319a
Author: Thomas Schatzl <tschatzl at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/742e319a21c767d8a93e13048add961f5ca8c5d7
Stats: 18 lines in 1 file changed: 3 ins; 4 del; 11 mod
8314157: G1: "yielded" is not initialized on some paths after JDK-8140326
Reviewed-by: ayang, iwalulya
-------------
PR: https://git.openjdk.org/jdk/pull/15359
More information about the hotspot-gc-dev
mailing list