RFR: 8300769: Remove G1CollectionSet::_inc_bytes_used_before

Thomas Schatzl tschatzl at openjdk.org
Mon Jan 23 10:25:04 UTC 2023


On Fri, 20 Jan 2023 22:26:19 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> I think `_bytes_used` is enough; the `_before` suffix adds nothing and it's confusing -- there's no counterpart like `_bytes_used_after`.

I considered that, but you could argue that the metric gathered here is "bytes used before" (gc, in the collection set). The "bytes used after" is calculated on the spot when it's needed just before passing it on to JFR.
I'm good either way, if you still think it's better to remove the `_before` or the second reviewer suggests it too, I'll do the rename (in another RFE).

-------------

PR: https://git.openjdk.org/jdk/pull/12113


More information about the hotspot-gc-dev mailing list