RFR: 8300127: Serial: Remove unnecessary from-space iteration in DefNewGeneration::oop_since_save_marks_iterate

Thomas Schatzl tschatzl at openjdk.org
Wed Jan 25 16:44:45 UTC 2023


On Fri, 13 Jan 2023 17:19:03 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Converting no-ops to assertions in young-gen obj iteration.
> 
> Test: hotspot_gc

Lgtm, please update the comment before pushing.

src/hotspot/share/gc/serial/defNewGeneration.inline.hpp line 94:

> 92: template <typename OopClosureType>
> 93: void DefNewGeneration::oop_since_save_marks_iterate(OopClosureType* cl) {
> 94:   // no allocation in from-space (eden/from)

I found the comment a bit confusing (and not conforming to style), here's an attempt to improve.
Suggestion:

  // No allocation in eden and from-space, so no iteration required.

-------------

Marked as reviewed by tschatzl (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11995


More information about the hotspot-gc-dev mailing list