RFR: 8300127: Serial: Remove unnecessary from-space iteration in DefNewGeneration::oop_since_save_marks_iterate [v2]
Albert Mingkun Yang
ayang at openjdk.org
Wed Jan 25 20:12:08 UTC 2023
On Wed, 25 Jan 2023 16:39:48 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>>
>> review
>
> src/hotspot/share/gc/serial/defNewGeneration.inline.hpp line 94:
>
>> 92: template <typename OopClosureType>
>> 93: void DefNewGeneration::oop_since_save_marks_iterate(OopClosureType* cl) {
>> 94: // no allocation in from-space (eden/from)
>
> I found the comment a bit confusing (and not conforming to style), here's an attempt to improve.
> Suggestion:
>
> // No allocation in eden and from-space, so no iteration required.
I was using the `from-space` term from copying GC algo to refer both eden and from spaces in the code.
-------------
PR: https://git.openjdk.org/jdk/pull/11995
More information about the hotspot-gc-dev
mailing list