RFR: 8310311: Serial: move Generation::contribute_scratch to DefNewGeneration [v2]

Thomas Schatzl tschatzl at openjdk.org
Tue Jul 4 08:32:57 UTC 2023


On Fri, 30 Jun 2023 12:13:09 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Simple cleanup to move a method from base-class to  sub-class.
>> 
>> Test: hotspot_gc
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   s1-contribute-scratch

src/hotspot/share/gc/serial/defNewGeneration.cpp line 989:

> 987:   }
> 988: 
> 989:   constexpr static size_t MinFreeScratchWords = 100;

Is there a reason this needs to be a `constexpr static` when a simple `const` seems to be sufficient?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14540#discussion_r1251684920


More information about the hotspot-gc-dev mailing list