RFR: 8310311: Serial: move Generation::contribute_scratch to DefNewGeneration [v2]

Albert Mingkun Yang ayang at openjdk.org
Mon Jul 31 09:51:22 UTC 2023


On Tue, 4 Jul 2023 08:28:21 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   s1-contribute-scratch
>
> src/hotspot/share/gc/serial/defNewGeneration.cpp line 989:
> 
>> 987:   }
>> 988: 
>> 989:   constexpr static size_t MinFreeScratchWords = 100;
> 
> Is there a reason this needs to be a `constexpr static` when a simple `const` seems to be sufficient?

Dropped `static`. `constexpr` makes it more a num literal. (The generated release asm is identical anyway.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/14540#discussion_r1279057668


More information about the hotspot-gc-dev mailing list