RFR: 8311514: Incorrect regex in TestMetaSpaceLog.java

Daohan Qu dqu at openjdk.org
Thu Jul 6 11:17:17 UTC 2023


On Thu, 6 Jul 2023 10:49:00 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> The test will fail should the JVM ever change that format, right?

I believe it will, except for some coincidence with a very very low possibility (eg, it matches a text that is embedded in some other log with a totally different meaning).

This reminds me of changing this regex to match more parts of this log, which will make it more likely to fail if this log changes.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14782#issuecomment-1623487365


More information about the hotspot-gc-dev mailing list