RFR: 8311514: Incorrect regex in TestMetaSpaceLog.java

Daohan Qu dqu at openjdk.org
Fri Jul 7 11:18:53 UTC 2023


On Thu, 6 Jul 2023 10:49:00 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>>> Good catch. But is this guaranteed to always be in K?
>> 
>> Hi Thomas! That's a good question and I believe the answer is yes.
>> 
>> This message is printed here in the function `MetaspaceUtils::print_metaspace_change()`:
>> https://github.com/openjdk/jdk/blob/356067d03f964fd0f24a055cfd772e27c8939812/src/hotspot/share/memory/metaspace.cpp#L163-L189
>> 
>> And the definition of macros `HEAP_CHANGE_FORMAT` and `HEAP_CHANGE_FORMAT_ARGS` is:
>> https://github.com/openjdk/jdk/blob/356067d03f964fd0f24a055cfd772e27c8939812/src/hotspot/share/utilities/globalDefinitions.hpp#L412-L417
>
>> > Good catch. But is this guaranteed to always be in K?
>> 
>> Hi Thomas! That's a good question and I believe the answer is yes.
>> 
> 
> Okay, thanks for checking. The test will fail should the JVM ever change that format, right?

Hi @tstuefe, could you please sponsor this change? Thanks in advance!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14782#issuecomment-1625259002


More information about the hotspot-gc-dev mailing list