RFR: 8311821: Simplify ParallelGCThreadsConstraintFunc after CMS removal [v3]

[Kim Barrett]

On Fri, 21 Jul 2023 20:11:02 GMT, Jenny Shivayogi <duke at openjdk.org> wrote:

>> Code oddities reported by SonarCloud after CMS removal
>> Fix: moving ParallelGCThreadsConstraintFuncParallel to shared code as ParallelGCThreadsConstraintFunc
>
> Jenny Shivayogi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   eliminate ParallelGCThreadsConstraintFunc

Other than the suggestion for an additional comment, this looks good.

src/hotspot/share/gc/shared/gc_globals.hpp line 136:

> 134:   product(uint, ParallelGCThreads, 0,                                       \
> 135:           "Number of parallel threads parallel gc will use")                \
> 136:           range(0, INT_MAX)                                                 \

A comment to explain the range restriction seems useful.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14965#pullrequestreview-1541806777
PR Review Comment: https://git.openjdk.org/jdk/pull/14965#discussion_r1271072343