RFR: 8311821: Simplify ParallelGCThreadsConstraintFunc after CMS removal [v3]
Aleksey Shipilev
shade at openjdk.org
Mon Jul 24 11:50:46 UTC 2023
On Fri, 21 Jul 2023 20:21:54 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Jenny Shivayogi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> eliminate ParallelGCThreadsConstraintFunc
>
> src/hotspot/share/gc/shared/gc_globals.hpp line 136:
>
>> 134: product(uint, ParallelGCThreads, 0, \
>> 135: "Number of parallel threads parallel gc will use") \
>> 136: range(0, INT_MAX) \
>
> A comment to explain the range restriction seems useful.
+1. Something like:
/* notice: the max range value here is INT_MAX not UINT_MAX */ \
/* to protect from overflows */ \
product(uint, ParallelGCThreads, 0, \
"Number of parallel threads parallel gc will use") \
range(0, INT_MAX) \
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14965#discussion_r1272153714
More information about the hotspot-gc-dev
mailing list