RFR: 8272147: Consolidate preserved marks handling with other STW collectors [v2]
Guoxiong Li
gli at openjdk.org
Tue Jun 6 17:02:35 UTC 2023
On Tue, 6 Jun 2023 08:00:45 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> The methods `MarkSweep::adjust_pointer` and `PreservedMarks::adjust_during_full_gc` have different implementations. The method `MarkSweep::adjust_pointer` seems doing more thing. So in `MarkSweep::adjust_marks`, I use `get_stack` to get the stack and invoke `MarkSweep::adjust_pointer` explicitly. If you can confirm `PreservedMarks::adjust_during_full_gc` is good to replace `MarkSweep::adjust_pointer`, I will remove `get_stack` and use `PreservedMarks::adjust_during_full_gc` instead of `MarkSweep::adjust_pointer`.
>
> You can replace that code with `PreservedMarks::adjust_during_full_gc` from what I can see; the additional code in `MarkSweep::adjust_pointer` only deals with the generic case if the passed `oop` is null, which can't be the case for oops in the preserved marks set.
I updated the code just now.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14274#discussion_r1220003565
More information about the hotspot-gc-dev
mailing list