RFR: 8309675: Generational ZGC: compiler/gcbarriers/UnsafeIntrinsicsTest.java fails in nmt_commit

Axel Boldt-Christmas aboldtch at openjdk.org
Thu Jun 8 18:28:41 UTC 2023


On Thu, 8 Jun 2023 18:05:46 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> The failure happens because we have extra verification code that is incorrect to use when calling the NMT tracking code. 
> 
> The fix is to simply inline the address calculation code *without* the verification code.
> 
> This fixes a tier3 failure. I'm going to run this through more extensive testing but it would be good to get this reviewed.

Guess this hit the dereference test. 
Could probably use `zaddress_unsafe` as well?
Either solution works.

-------------

Marked as reviewed by aboldtch (Committer).

PR Review: https://git.openjdk.org/jdk/pull/14382#pullrequestreview-1470542059


More information about the hotspot-gc-dev mailing list