RFR: 8309675: Generational ZGC: compiler/gcbarriers/UnsafeIntrinsicsTest.java fails in nmt_commit

Stefan Karlsson stefank at openjdk.org
Thu Jun 8 18:53:55 UTC 2023


On Thu, 8 Jun 2023 18:05:46 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> The failure happens because we have extra verification code that is incorrect to use when calling the NMT tracking code. 
> 
> The fix is to simply inline the address calculation code *without* the verification code.
> 
> This fixes a tier3 failure. I'm going to run this through more extensive testing but it would be good to get this reviewed.

Yes, that's a good suggestion, though I think I'd prefer to stick with the current solution because then it is more clear that the code matches the comment in nmt_commit.

Thanks for reviewing!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/14382#issuecomment-1583164038


More information about the hotspot-gc-dev mailing list