RFR: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition

Stefan Karlsson stefank at openjdk.org
Tue Jun 13 05:56:19 UTC 2023


There's a section in the test that waits up to 10 seconds for a string to be deduplicated and then does a final verification that the string was correctly deduplicated. However, the initial waiting gets passed the wrong comparison string, which has the effect that this test always waits for 10 seconds before proceeding.

The problem is here:

            if (!waitForDeduplication(dupString3, baseString)) {
                if (getValue(dupString3) != getValue(internedString)) {

where the first line should say:

            if (!waitForDeduplication(dupString3, internedString)) {

-------------

Commit messages:
 - 8309890: TestStringDeduplicationInterned.java waits for the wrong condition

Changes: https://git.openjdk.org/jdk/pull/14437/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=14437&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8309890
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/14437.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/14437/head:pull/14437

PR: https://git.openjdk.org/jdk/pull/14437


More information about the hotspot-gc-dev mailing list