RFR: 8309890: TestStringDeduplicationInterned.java waits for the wrong condition

Axel Boldt-Christmas aboldtch at openjdk.org
Tue Jun 13 06:29:51 UTC 2023


On Tue, 13 Jun 2023 05:48:32 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> There's a section in the test that waits up to 10 seconds for a string to be deduplicated and then does a final verification that the string was correctly deduplicated. However, the initial waiting gets passed the wrong comparison string, which has the effect that this test always waits for 10 seconds before proceeding.
> 
> The problem is here:
> 
>             if (!waitForDeduplication(dupString3, baseString)) {
>                 if (getValue(dupString3) != getValue(internedString)) {
> 
> where the first line should say:
> 
>             if (!waitForDeduplication(dupString3, internedString)) {

Marked as reviewed by aboldtch (Committer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/14437#pullrequestreview-1476344420


More information about the hotspot-gc-dev mailing list