RFR: 8308633: Increase precision of timestamps in g1 log [v2]

Kim Barrett kbarrett at openjdk.org
Fri Jun 23 22:41:13 UTC 2023


On Fri, 23 Jun 2023 09:42:21 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this improvement adding a digit to log timestamp to improve output. On modern machines, for some pauses, this can lead to sub-phase timings not adding up, and during development, extra work to evaluate different options.
>> Also that rounding error starts to matter for e.g. pauses < a few ms. 
>> 
>> I am aware that there is a duplication of the timestamp format in the files, and this change did not improve that as this would be a different issue. Not sure where to put such a global constant though, any suggestions?
>> 
>> Testing: gha, looking at log files
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix gtests

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/14594#pullrequestreview-1496142613


More information about the hotspot-gc-dev mailing list