RFR: 8319373: Serial: Refactor dirty cards scanning during Young GC [v2]

Fri Nov 10 10:57:28 UTC 2023

On Fri, 10 Nov 2023 09:08:30 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - review
>>  - Merge branch 'master' into s1-young-gc
>>  - s1-young-gc
>
> src/hotspot/share/gc/serial/cardTableRS.cpp line 410:
> 
>> 408:     }
>> 409: 
>> 410:     // final obj in dirty-chunk crosses card-boundary
> 
> Suggestion:
> 
>     // Last object in dirty chunk crosses card-boundary.
> 
> 
> I think "last" is the more appropriate term compared to "final" as to me "final" indicates that this is the overall very last object.

"last" can mean "previous" so I tried to avoid it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16492#discussion_r1389246270