RFR: 8319373: Serial: Refactor dirty cards scanning during Young GC [v2]

[Albert Mingkun Yang]

On Fri, 10 Nov 2023 09:21:35 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - review
>>  - Merge branch 'master' into s1-young-gc
>>  - s1-young-gc
>
> src/hotspot/share/gc/serial/cardTableRS.cpp line 378:
> 
>> 376:       break;
>> 377:     }
>> 378:     i_card += sizeof(Word);
> 
> `sizeof(Word) / sizeof(CardValue)` ? Or assert that `sizeof(CardValue) == 1` somewhere.

I don't think the impl assumes each card is one-byte. In Word-comparison, the increment is word-size regardless of the card-size.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16492#discussion_r1389311758