RFR: 8319373: Serial: Refactor dirty cards scanning during Young GC [v8]

[Albert Mingkun Yang]

On Thu, 16 Nov 2023 19:05:03 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   next-obj-card
>
> src/hotspot/share/gc/serial/cardTableRS.cpp line 370:
> 
>> 368:   // Word comparison
>> 369:   while (i_card + sizeof(Word) <= end_card) {
>> 370:     Word* i_word = reinterpret_cast<Word*>(i_card);
> 
> Maybe CardTable should provide a helper for accessing a "row" of cards?

g1RemSet.cpp also has sth like this. I will handle them together in another PR.

> src/hotspot/share/gc/serial/cardTableRS.hpp line 56:
> 
>> 54:   static void clear_cards(CardValue* start, CardValue* end);
>> 55: 
>> 56:   static CardTable::CardValue* find_first_dirty_card(CardValue* const start_card,
> 
> CardTable qualification for return type isn't needed here, or a couple lines later.

Got compilation error without it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16492#discussion_r1396241610
PR Review Comment: https://git.openjdk.org/jdk/pull/16492#discussion_r1396241828