RFR: 8319373: Serial: Refactor dirty cards scanning during Young GC [v8]

[Kim Barrett]

On Thu, 16 Nov 2023 19:37:44 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> src/hotspot/share/gc/serial/cardTableRS.hpp line 56:
>> 
>>> 54:   static void clear_cards(CardValue* start, CardValue* end);
>>> 55: 
>>> 56:   static CardTable::CardValue* find_first_dirty_card(CardValue* const start_card,
>> 
>> CardTable qualification for return type isn't needed here, or a couple lines later.
>
> Got compilation error without it.

That is weird.  Which compiler(s)?  Unqualified CardValue should be fine here, and is used in other places in the same signature.  It would be needed in the (out of class) definition, where the scoping is different, but shouldn't be needed here (within the class definition).  (That scoping issue could be removed by using trailing return type, which has different scope too, but that would be strange style in HotSpot.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16492#discussion_r1397718399