RFR: 8319373: Serial: Refactor dirty cards scanning during Young GC [v8]

[Albert Mingkun Yang]

On Fri, 17 Nov 2023 21:33:43 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> From clang 14:
>> 
>> 
>> cardTableRS.cpp:349:1: error: unknown type name 'CardValue'
>> CardValue* CardTableRS::find_first_dirty_card(CardValue* const start_card,
>> 
>> 
>> From gcc 13:
>> 
>> 
>> cardTableRS.cpp:349:1: error: 'CardValue' does not name a type; did you mean 'JavaValue'?
>>   349 | CardValue* CardTableRS::find_first_dirty_card(CardValue* const start_card,
>> 
>> 
>> Can you build successfully without the prefix?
>
> My original comment was about the .hpp file.  My followup comment noted that the qualification is needed in
> the .cpp file, because of the different scoping (in the class definition body vs outside it).  The error you are
> mentioning is in the .cpp file.  A leading return type is not in the scope of the function.

I didn't understand your request. Compiling works fine if I remove the prefix in header only. However, I think it's more consistent when the declaration in header and definition have the identical signature.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16492#discussion_r1397948336