RFR: 8319373: Serial: Refactor dirty cards scanning during Young GC [v8]

[Kim Barrett]

On Fri, 17 Nov 2023 22:20:30 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> My original comment was about the .hpp file.  My followup comment noted that the qualification is needed in
>> the .cpp file, because of the different scoping (in the class definition body vs outside it).  The error you are
>> mentioning is in the .cpp file.  A leading return type is not in the scope of the function.
>
> I didn't understand your request. Compiling works fine if I remove the prefix in header only. However, I think it's more consistent when the declaration in header and definition have the identical signature.

There are a number of ways in which a declaration and a separate definition may or even must differ. 
I think this is a false consistency, and confusing because the qualifier is unnecessary and eye catching.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16492#discussion_r1398086819