RFR: 8317358: G1: Make TestMaxNewSize use createTestJvm

Stefan Johansson sjohanss at openjdk.org
Mon Oct 9 10:59:33 UTC 2023


On Mon, 2 Oct 2023 15:09:49 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

> In addition remove deprecated `Long(long)` constructor and rewrite `compareTo` to use `> 0` instead of `== 1`.
> 
> Also remove unused `isRunningG1(String[] args)` and `checkIncompatibleNewSize(String[] flags)`
> 
> Minimal testing completed, will run tier testing before pushing.

>From what I can tell this test now fails when run with for example `-Xmn1g`. So I'm not sure if it really is a good idea to change this test to use `createTestJvm`. 

We could of course add this option to the requires list, but there are more options that can cause failures as well.

-------------

Changes requested by sjohanss (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16012#pullrequestreview-1664196844


More information about the hotspot-gc-dev mailing list