RFR: 8317358: G1: Make TestMaxNewSize use createTestJvm

Thomas Schatzl tschatzl at openjdk.org
Thu Oct 12 13:06:30 UTC 2023


On Mon, 2 Oct 2023 15:09:49 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

> In addition remove deprecated `Long(long)` constructor and rewrite `compareTo` to use `> 0` instead of `== 1`.
> 
> Also remove unused `isRunningG1(String[] args)` and `checkIncompatibleNewSize(String[] flags)`
> 
> Minimal testing completed, will run tier testing before pushing.

Reconsidering and now tending to agree with @kstefanj about that heap size tests are too sensitive too various options (too many to list them all) to be worth the potential gain by running it with random options.

Maybe some more control about the flags like suggested in some other PR would make my concerns go away.

-------------

Changes requested by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16012#pullrequestreview-1673994502


More information about the hotspot-gc-dev mailing list