RFR: 8317228: GC: Make TestXXXHeapSizeFlags use createTestJvm [v4]

Stefan Johansson sjohanss at openjdk.org
Mon Oct 16 10:34:22 UTC 2023


On Fri, 13 Oct 2023 14:32:56 GMT, Leo Korinth <lkorinth at openjdk.org> wrote:

>> Minor testing done, I will test more later with other fixes.
>
> Leo Korinth has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add flag-sensitive key to TEST.ROOT

test/hotspot/jtreg/TEST.ROOT line 35:

> 33: # randomness:           test uses randomness, test cases differ from run to run
> 34: # cgroups:              test uses cgroups
> 35: keys=stress headful intermittent randomness cgroups flag-sensitive

Maybe add a comment above about the key, similar to the others. Something like: 

# flag-sensitive:       test is sensitive to certain flags and might fail when flags are passed in

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15986#discussion_r1360411062


More information about the hotspot-gc-dev mailing list