RFR: 8318647: Serial: Refactor BlockOffsetTable

Albert Mingkun Yang ayang at openjdk.org
Wed Oct 25 11:20:36 UTC 2023


On Wed, 25 Oct 2023 10:57:45 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> src/hotspot/share/gc/serial/serialBlockOffsetTable.cpp line 84:
>> 
>>> 82: }
>>> 83: 
>>> 84: // Write the backskip value for each region.
>> 
>> Suggestion:
>> 
>> // Write the backskip value for the given region.
>
> Note that region isn't defined very exactly. Here it is (apparently) the memory from `blk_start` to `blk_end`, but later it is also used as "area containing the same backskip value". Maybe there is some better wording to be found.

"region" in this file always means "logarithmic region". If we refer to `[blk_start, blk_end]`, "block" should be used.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16304#discussion_r1371565110


More information about the hotspot-gc-dev mailing list