RFR: 8318908: Parallel: Remove ExtendedCardValue

Stefan Johansson sjohanss at openjdk.org
Tue Oct 31 12:47:31 UTC 2023


On Thu, 26 Oct 2023 15:03:27 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple removing some dead code; after this, a card is either clean or dirty.

Looks good, just a comment/question? Feel free to integrate if you don't see a need to change the name.

src/hotspot/share/gc/parallel/psCardTable.cpp line 390:

> 388: }
> 389: 
> 390: bool PSCardTable::addr_is_marked_imprecise(void *addr) {

Does it make sense to keep this name when we don't have the "precise" counterpart and what all it does is checking if the card is dirty?

-------------

Marked as reviewed by sjohanss (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16380#pullrequestreview-1706212146
PR Review Comment: https://git.openjdk.org/jdk/pull/16380#discussion_r1377530439


More information about the hotspot-gc-dev mailing list