RFR: 8318908: Parallel: Remove ExtendedCardValue
Albert Mingkun Yang
ayang at openjdk.org
Tue Oct 31 13:03:33 UTC 2023
On Tue, 31 Oct 2023 12:44:24 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:
>> Simple removing some dead code; after this, a card is either clean or dirty.
>
> src/hotspot/share/gc/parallel/psCardTable.cpp line 390:
>
>> 388: }
>> 389:
>> 390: bool PSCardTable::addr_is_marked_imprecise(void *addr) {
>
> Does it make sense to keep this name when we don't have the "precise" counterpart and what all it does is checking if the card is dirty?
Indeed odd. I will rename it to sth else in a follow-up PR. Even "marked" is weird here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16380#discussion_r1377550662
More information about the hotspot-gc-dev
mailing list