RFR: 8318908: Parallel: Remove ExtendedCardValue

Stefan Johansson sjohanss at openjdk.org
Tue Oct 31 13:31:34 UTC 2023


On Tue, 31 Oct 2023 13:00:46 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> src/hotspot/share/gc/parallel/psCardTable.cpp line 390:
>> 
>>> 388: }
>>> 389: 
>>> 390: bool PSCardTable::addr_is_marked_imprecise(void *addr) {
>> 
>> Does it make sense to keep this name when we don't have the "precise" counterpart and what all it does is checking if the card is dirty?
>
> Indeed odd. I will rename it to sth else in a follow-up PR. Even "marked" is weird here.

Sounds good, my first thought was `addr_is_dirty(void* addr)`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16380#discussion_r1377588481


More information about the hotspot-gc-dev mailing list