RFR: 8315855: G1: Revise signature of set_humongous_candidate

Thomas Schatzl tschatzl at openjdk.org
Fri Sep 8 08:18:39 UTC 2023


On Thu, 7 Sep 2023 11:57:58 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple removing redundant method arg around humongous candidates.

src/hotspot/share/gc/g1/g1HeapRegionAttr.hpp line 138:

> 136:            "Region attributes at index " INTPTR_FORMAT " should be default but is %s", index, get_by_index(index).get_type_str());
> 137:     // Humongous candidates must have complete remset.
> 138:     const bool remset_is_tracked = true;

Wouldn't it be preferable directly asserting this instead of only "requiring" this in a comment?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15617#discussion_r1319527051


More information about the hotspot-gc-dev mailing list