RFR: 8315855: G1: Revise signature of set_humongous_candidate

[Albert Mingkun Yang]

On Fri, 8 Sep 2023 08:15:32 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Simple removing redundant method arg around humongous candidates.
>
> src/hotspot/share/gc/g1/g1HeapRegionAttr.hpp line 138:
> 
>> 136:            "Region attributes at index " INTPTR_FORMAT " should be default but is %s", index, get_by_index(index).get_type_str());
>> 137:     // Humongous candidates must have complete remset.
>> 138:     const bool remset_is_tracked = true;
> 
> Wouldn't it be preferable directly asserting this instead of only "requiring" this in a comment?

That would be ideal, but I don't see an easy way retrieving `HeapRegion` by index in this context.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15617#discussion_r1319744703