RFR: 8316906 Clarify TLABWasteTargetPercent flag
Albert Mingkun Yang
ayang at openjdk.org
Tue Sep 26 08:35:14 UTC 2023
On Mon, 25 Sep 2023 15:42:37 GMT, Ludvig Janiuk <lujaniuk at openjdk.org> wrote:
> This flag is currently described as "Percentage of Eden that can be wasted". However, it does not address all kinds of waste. It specifically only controls the waste due to half-full TLABs at GC time. I propose to clarify this description, because it took me a lot of time to figure it out.
src/hotspot/share/gc/shared/tlab_globals.hpp line 76:
> 74: /* in a division expression. */ \
> 75: product(uintx, TLABWasteTargetPercent, 1, \
> 76: "Percentage of Eden that can be wasted (half-full TLABs at GC)" \
The trailing `)` is removed, so GHA is failing.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15904#discussion_r1336834362
More information about the hotspot-gc-dev
mailing list