RFR: 8316906 Clarify TLABWasteTargetPercent flag [v2]

Ludvig Janiuk lujaniuk at openjdk.org
Tue Sep 26 09:06:15 UTC 2023


On Tue, 26 Sep 2023 08:32:03 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Ludvig Janiuk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   More details, fix parenthesis
>
> src/hotspot/share/gc/shared/tlab_globals.hpp line 76:
> 
>> 74:   /* in a division expression.                              */              \
>> 75:   product(uintx, TLABWasteTargetPercent, 1,                                 \
>> 76:           "Percentage of Eden that can be wasted (half-full TLABs at GC)"   \
> 
> The trailing `)` is removed, so GHA is failing.

My bad, thank you for spotting it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15904#discussion_r1336872858


More information about the hotspot-gc-dev mailing list