RFR: 8329570: G1: Excessive is_obj_dead_cond calls in verification

[Aleksey Shipilev]

On Wed, 3 Apr 2024 12:30:02 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> With the new G1VerifyFailureCounter in the _2 patch, we could even pull this a bit further and remove the other_failures counter:
>> https://github.com/openjdk/jdk/commit/8ee0b46f64bb609b4c0473fb35df47908bbeced9
>> https://github.com/openjdk/jdk/compare/master...stefank:jdk:8329570_is_obj_dead_cond_3
>> :shrug:
>
> I was think of something similar, also makes the iteration actually stop at `G1MaxVerifyFailures` instead of at some related but arbitrary larger number.

Honestly, I think we are overthinking this. The original patch gives us a major bang for the buck, and it has a benefit of being obvious and thus very backportable. I suggest we go with the current version, and then do any other followups.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18595#discussion_r1550153431