RFR: 8329570: G1: Excessive is_obj_dead_cond calls in verification

[Axel Boldt-Christmas]

On Wed, 3 Apr 2024 17:17:38 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> I was think of something similar, also makes the iteration actually stop at `G1MaxVerifyFailures` instead of at some related but arbitrary larger number.
>
> Honestly, I think we are overthinking this. The original patch gives us a major bang for the buck, and it has a benefit of being obvious and thus very backportable. I suggest we go with the current version, and then do any other followups.

I can clarify my position. I completely agree with @shipilev, hence my approval of still stands. I think the current fix is a very reasonable solution to the problem.

But my initial thought / reaction when looking at the code was "why is the closure have mutable state" and "the check agains `G1MaxVerifyFailures` looks strange".

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18595#discussion_r1550180783