RFR: 8329603: G1: Merge G1BlockOffsetTablePart into G1BlockOffsetTable [v2]

[Albert Mingkun Yang]

On Fri, 5 Apr 2024 07:14:33 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Hi all,
>> 
>> This patch merges `G1BlockOffsetTablePart` into `G1BlockOffsetTable`. The previous fields `_reserved` and `_offset_base` of `G1BlockOffsetTable` are marked as `static` so that they can be shared by BOTs of all the heap regions.
>> 
>> The tests `make test-tier1_gc` passed locally. Thanks for taking the time to review.
>> 
>> Best Regards,
>> -- Guoxiong
>
> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use a simple/unified BOT.

src/hotspot/share/gc/g1/g1BlockOffsetTable.cpp line 166:

> 164: //         blk_start
> 165: //
> 166: void G1BlockOffsetTable::update_for_block_work(HeapWord* blk_start,

Some indentation issues.

src/hotspot/share/gc/g1/g1BlockOffsetTable.hpp line 43:

> 41: // start of the chunk that includes the first word of the subregion.
> 42: //
> 43: // Each G1BlockOffsetTable is owned by a HeapRegion.

Need revision.

src/hotspot/share/gc/g1/g1BlockOffsetTable.hpp line 134:

> 132:   }
> 133: 
> 134:   void set_for_starts_humongous(HeapRegion* hr, HeapWord* obj_top, size_t fill_size);

I feel this doesn't belong to BOT. Can probably be dealt with in another ticket.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18634#discussion_r1553171210
PR Review Comment: https://git.openjdk.org/jdk/pull/18634#discussion_r1553156558
PR Review Comment: https://git.openjdk.org/jdk/pull/18634#discussion_r1553170536