RFR: 8329603: G1: Merge G1BlockOffsetTablePart into G1BlockOffsetTable [v2]

[Guoxiong Li]

On Fri, 5 Apr 2024 08:08:15 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use a simple/unified BOT.
>
> src/hotspot/share/gc/g1/g1BlockOffsetTable.hpp line 43:
> 
>> 41: // start of the chunk that includes the first word of the subregion.
>> 42: //
>> 43: // Each G1BlockOffsetTable is owned by a HeapRegion.
> 
> Need revision.

I think it is good to delete this line and the blank line. What do you think about it?

> I feel this doesn't belong to BOT. Can probably be dealt with in another ticket.

OK.

What about the method `G1BlockOffsetTable::verify`? Is it good to be moved to `HeapRegion` and change the name as `verify_bot`, `verify_BOT` or `verify_block_offset_table`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18634#discussion_r1553187744
PR Review Comment: https://git.openjdk.org/jdk/pull/18634#discussion_r1553197736