RFR: 8329766: Serial: Refactor SerialBlockOffsetTable API

Guoxiong Li gli at openjdk.org
Fri Apr 5 12:11:10 UTC 2024


On Fri, 5 Apr 2024 11:23:16 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple refactoring towards unifying BOT API between Serial and Parallel.

Looks good.

src/hotspot/share/gc/serial/serialBlockOffsetTable.cpp line 80:

> 78: }
> 79: 
> 80: static void fill_range(uint8_t* start, uint8_t* end, uint8_t v) {

The name `offset` may be better to a simple letter `v`. But it is also OK now.

-------------

Marked as reviewed by gli (Committer).

PR Review: https://git.openjdk.org/jdk/pull/18651#pullrequestreview-1982984968
PR Review Comment: https://git.openjdk.org/jdk/pull/18651#discussion_r1553508900


More information about the hotspot-gc-dev mailing list