RFR: 8329766: Serial: Refactor SerialBlockOffsetTable API
Ivan Walulya
iwalulya at openjdk.org
Mon Apr 8 15:40:10 UTC 2024
On Fri, 5 Apr 2024 11:23:16 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
> Simple refactoring towards unifying BOT API between Serial and Parallel.
Changes requested by iwalulya (Reviewer).
src/hotspot/share/gc/serial/serialBlockOffsetTable.cpp line 81:
> 79:
> 80: static void fill_range(uint8_t* start, uint8_t* end, uint8_t v) {
> 81: // + 1 for inclusive
Suggestion:
// + 1 for inclusive.
src/hotspot/share/gc/serial/serialBlockOffsetTable.hpp line 65:
> 63: }
> 64:
> 65: // Mapping from address to object start array entry
Suggestion:
// Mapping from address to object start array entry.
src/hotspot/share/gc/serial/serialBlockOffsetTable.hpp line 68:
> 66: uint8_t* entry_for_addr(const void* const p) const;
> 67:
> 68: // Mapping from object start array entry to address of first word
Suggestion:
// Mapping from object start array entry to address of first word.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18651#pullrequestreview-1986800079
PR Review Comment: https://git.openjdk.org/jdk/pull/18651#discussion_r1556048211
PR Review Comment: https://git.openjdk.org/jdk/pull/18651#discussion_r1556048454
PR Review Comment: https://git.openjdk.org/jdk/pull/18651#discussion_r1556048664
More information about the hotspot-gc-dev
mailing list