RFR: 8329658: Serial: Refactor ContiguousSpace::_next_compaction_space [v4]

Guoxiong Li gli at openjdk.org
Tue Apr 9 14:02:09 UTC 2024


On Tue, 9 Apr 2024 13:40:08 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Actually, it is not only about failed promotion. When the to-space is not empty, we must deal with it. But usually, the failed promotion causes the to-space not empty.
>
> Can non-empty-to-space occur without fail-promotion?

IMO, I think it is good to say: if the to-space is not empty, we need to deal with it, regardless whether it is failed promotion. Even only the failed promotion causes non empty to-space.

What do you think about it?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18666#discussion_r1557681753


More information about the hotspot-gc-dev mailing list