RFR: 8329658: Serial: Refactor ContiguousSpace::_next_compaction_space [v4]

Albert Mingkun Yang ayang at openjdk.org
Tue Apr 9 14:08:10 UTC 2024


On Tue, 9 Apr 2024 13:59:47 GMT, Guoxiong Li <gli at openjdk.org> wrote:

>> Can non-empty-to-space occur without fail-promotion?
>
> IMO, I think it is good to say: if the to-space is not empty, we need to deal with it, regardless whether it is failed promotion. Even only the failed promotion causes non empty to-space.
> 
> What do you think about it?

I have no preference regarding using a local-var or not.

(My understanding is that non-empty-to-space == promotion-failure; if that's not true, I wanna refresh my knowledge on that.)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18666#discussion_r1557699719


More information about the hotspot-gc-dev mailing list