RFR: 8329767: G1: Move G1BlockOffsetTable::set_for_starts_humongous to HeapRegion
Albert Mingkun Yang
ayang at openjdk.org
Tue Apr 9 17:46:09 UTC 2024
On Tue, 9 Apr 2024 16:47:41 GMT, Guoxiong Li <gli at openjdk.org> wrote:
> Hi all,
>
> This patch moves the method `G1BlockOffsetTable::set_for_starts_humongous` into `HeapRegion::set_starts_humongous` and marks `G1BlockOffsetTable::update_for_block(HeapWord* blk_start, size_t size)` as public (because it delegates to another public method which has the same name).
>
> Thanks for taking the time to review.
>
> Best Regards,
> -- Guoxiong
src/hotspot/share/gc/g1/g1BlockOffsetTable.hpp line 127:
> 125: }
> 126:
> 127: void update_for_block(HeapWord* blk_start, size_t size) {
Maybe this can be done at the caller side? (The API would be easier with fewer overloading.)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18701#discussion_r1558074646
More information about the hotspot-gc-dev
mailing list