RFR: 8329767: G1: Move G1BlockOffsetTable::set_for_starts_humongous to HeapRegion [v2]

Guoxiong Li gli at openjdk.org
Wed Apr 10 04:12:26 UTC 2024


On Tue, 9 Apr 2024 17:43:44 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove method update_for_block.
>
> src/hotspot/share/gc/g1/g1BlockOffsetTable.hpp line 127:
> 
>> 125:   }
>> 126: 
>> 127:   void update_for_block(HeapWord* blk_start, size_t size) {
> 
> Maybe this can be done at the caller side? (The API would be easier with fewer overloading.)

I removed the method `void update_for_block(HeapWord* blk_start, size_t size)` just now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18701#discussion_r1558812417


More information about the hotspot-gc-dev mailing list