RFR: 8329781: Serial: Remove serialFullGC.inline.hpp

Albert Mingkun Yang ayang at openjdk.org
Thu Apr 11 14:11:42 UTC 2024


On Thu, 11 Apr 2024 13:58:05 GMT, Guoxiong Li <gli at openjdk.org> wrote:

> Hi all,
> 
> This patch moves the content of `serialFullGC.inline.hpp` to `serialFullGC.cpp`. Thanks for taking the time to review.
> 
> Best Regards,
> -- Guoxiong

src/hotspot/share/gc/serial/serialFullGC.cpp line 612:

> 610: }
> 611: 
> 612: inline size_t SerialFullGC::adjust_pointers(oop obj) {

I see only a single caller of this method; maybe this method can be inlined completely and drop this api.

src/hotspot/share/gc/serial/serialFullGC.cpp line 616:

> 614: }
> 615: 
> 616: template <class T> inline void SerialFullGC::adjust_pointer(T* p) {

This new code should be after "void MarkAndPushClosure::do_oop(narrowOop* p) { do_oop_work(p); }" so that `mark_and_push` is next to its caller.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18744#discussion_r1561087262
PR Review Comment: https://git.openjdk.org/jdk/pull/18744#discussion_r1561087774


More information about the hotspot-gc-dev mailing list