RFR: 8329781: Serial: Remove serialFullGC.inline.hpp [v2]

Guoxiong Li gli at openjdk.org
Thu Apr 11 15:03:59 UTC 2024


On Thu, 11 Apr 2024 14:08:38 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Guoxiong Li has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Move method.
>>  - Inline adjust_pointers.
>
> src/hotspot/share/gc/serial/serialFullGC.cpp line 612:
> 
>> 610: }
>> 611: 
>> 612: inline size_t SerialFullGC::adjust_pointers(oop obj) {
> 
> I see only a single caller of this method; maybe this method can be inlined completely and drop this api.

Inlined.

> src/hotspot/share/gc/serial/serialFullGC.cpp line 616:
> 
>> 614: }
>> 615: 
>> 616: template <class T> inline void SerialFullGC::adjust_pointer(T* p) {
> 
> This new code should be after "void MarkAndPushClosure::do_oop(narrowOop* p) { do_oop_work(p); }" so that `mark_and_push` is next to its caller.

Moved.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18744#discussion_r1561180920
PR Review Comment: https://git.openjdk.org/jdk/pull/18744#discussion_r1561181067


More information about the hotspot-gc-dev mailing list