RFR: 8330154: Serial: Remove TenuredSpace::update_for_block [v2]
Guoxiong Li
gli at openjdk.org
Fri Apr 12 15:08:45 UTC 2024
On Fri, 12 Apr 2024 14:50:51 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Simple move an API from space to old-gen, in preparation for complete encapsulation of BOT inside old-gen.
>
> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>
> s1-remove-space-bot
Looks good. One suggestion, but not a must.
src/hotspot/share/gc/serial/tenuredGeneration.cpp line 502:
> 500: while (start < archive_space.end()) {
> 501: size_t word_size = cast_to_oop(start)->size();;
> 502: _bts->update_for_block(start, start + word_size);
The `update_for_block` is moved from `TenuredSpace` to `TenuredGeneration`. What about using `TenuredGeneration::update_for_block` here? It is also inlined by the compiler.
-------------
Marked as reviewed by gli (Committer).
PR Review: https://git.openjdk.org/jdk/pull/18752#pullrequestreview-1997542151
PR Review Comment: https://git.openjdk.org/jdk/pull/18752#discussion_r1562684868
More information about the hotspot-gc-dev
mailing list