RFR: 8330154: Serial: Remove TenuredSpace::update_for_block [v2]
Albert Mingkun Yang
ayang at openjdk.org
Mon Apr 22 10:11:35 UTC 2024
On Fri, 12 Apr 2024 15:05:13 GMT, Guoxiong Li <gli at openjdk.org> wrote:
>> Albert Mingkun Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>>
>> s1-remove-space-bot
>
> src/hotspot/share/gc/serial/tenuredGeneration.cpp line 502:
>
>> 500: while (start < archive_space.end()) {
>> 501: size_t word_size = cast_to_oop(start)->size();;
>> 502: _bts->update_for_block(start, start + word_size);
>
> The `update_for_block` is moved from `TenuredSpace` to `TenuredGeneration`. What about using `TenuredGeneration::update_for_block` here? It is also inlined by the compiler.
Either is fine; I chose this way to make it explicit that this public api is called only by external users, not inside this class -- rather subjective.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18752#discussion_r1574491401
More information about the hotspot-gc-dev
mailing list